This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: updates ipld-dag-pb dep to version without .cid or .multihash properties #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
achingbrain
force-pushed
the
update-dag-pb-to-not-have-cid-property
branch
from
2b5edc5
to
9b12a1f
Compare
achingbrain
changed the title
achingbrain
force-pushed
the
update-dag-pb-to-not-have-cid-property
branch
2 times, most recently
from
4ecf656
to
5573131
Compare
achingbrain
force-pushed
the
update-dag-pb-to-not-have-cid-property
branch
from
0caf558
to
fda2bec
Compare
Follows on from ipld/js-ipld-dag-pb#99 and updates this module to not rely on DAGNodes having knowledge of their CIDs.
achingbrain
force-pushed
the
update-dag-pb-to-not-have-cid-property
branch
from
fda2bec
to
b0eab93
Compare
alanshaw
suggested changes
Nov 13, 2018
| }, | ||
| 'cid-base': { | ||
| default: 'base58btc', | ||
| describe: 'CID base to use.' | ||
| } |
There was a problem hiding this comment.
This has a lot of cross over with what's happening in #1552. Does this option need to be implemented in this PR? There's no added tests for it and what we have here has the potential to throw a lot of uncaught errors when requesting a base other than base58btc from a CID version 0 (see https://github.com/ipld/js-cid/blob/5653cbc479bcd8d0f676ccda84b22f5d241b65eb/src/index.js#L188).
There was a problem hiding this comment.
It just seemed like a natural thing to add. I can add a test or remove it, as you prefer.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on from ipld/js-ipld-dag-pb#99 and updates this module to not rely on DAGNodes having knowledge of their CIDs.