Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

node.add -> node.files.add #1791

Closed
wants to merge 1 commit into from
Closed

node.add -> node.files.add #1791

wants to merge 1 commit into from

Conversation

schollz
Copy link

@schollz schollz commented Dec 21, 2018

I found this helpful as there seems to have been an API change.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the commit @schollz

The changes look good. Can you amend your commit message to get commitlint CI job green?

@schollz
Copy link
Author

schollz commented Dec 21, 2018

@vasco-santos Okay, I'm going to try - let me know if I am getting it wrong

@alanshaw
Copy link
Member

@schollz the examples are correct for the code in master that will be released in 0.34.

More info on the breaking change here #1721

@alanshaw alanshaw closed this Dec 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants