This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: update hapi to v20 #3245
Merged
feat: update hapi to v20 #3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates hapi ecosystem modules to v20 BREAKING CHANGES: - Hapi has dropped support for node < 12
There was a problem hiding this comment.
Should we enable CI for node14 per https://github.com/ipfs/js-ipfs/blob/master/.travis.yml#L20 ?
|
Node 14 isn't working yet, something about streams has changed. I'll be doing a follow up with a fix. |
|
Refs: hapijs/hapi#4149 |
|
I'm going to merge this then do a follow up PR for node 14. |
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
Updates hapi ecosystem modules to v20 BREAKING CHANGES: - Hapi has dropped support for node < 12
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates hapi ecosystem modules to v20
BREAKING CHANGES: