fix: do not accept single items for ipfs.add (#3900)

The types allow passing single items to `ipfs.addAll` and multiple items
to `ipfs.add`.

Instead, only accept single items to `ipfs.add` and streams of item to
`ipfs.addAll` and fail with a more helpful error message if you do not
do this.

BREAKING CHANGE: errors will now be thrown if multiple items are passed to `ipfs.add` or single items to `ipfs.addAll` (n.b. you can still pass a list of a single item to `ipfs.addAll`)

src/add.js

@@ -1,6 +1,7 @@
 import { createAddAll } from './add-all.js'
 import last from 'it-last'
 import { configure } from './lib/configure.js'
+import { normaliseInput } from 'ipfs-core-utils/files/normalise-input-single'
 
 /**
  * @typedef {import('./types').HTTPClientExtraOptions} HTTPClientExtraOptions
@@ -18,7 +19,7 @@ export function createAdd (options) {
      */
     async function add (input, options = {}) {
       // @ts-ignore - last may return undefined if source is empty
-      return await last(all(input, options))
+      return await last(all(normaliseInput(input), options))
     }
     return add
   })(options)

src/block/put.js

@@ -25,7 +25,7 @@ export const createPut = configure(api => {
         signal: signal,
         searchParams: toUrlSearchParams(options),
         ...(
-          await multipartRequest(data, controller, options.headers)
+          await multipartRequest([data], controller, options.headers)
         )
       })
       res = await response.json()

src/config/replace.js

@@ -23,7 +23,7 @@ export const createReplace = configure(api => {
       signal,
       searchParams: toUrlSearchParams(options),
       ...(
-        await multipartRequest(uint8ArrayFromString(JSON.stringify(config)), controller, options.headers)
+        await multipartRequest([uint8ArrayFromString(JSON.stringify(config))], controller, options.headers)
       )
     })
 

src/dag/put.js

@@ -39,7 +39,7 @@ export const createPut = (codecs, options) => {
         signal,
         searchParams: toUrlSearchParams(settings),
         ...(
-          await multipartRequest(serialized, controller, settings.headers)
+          await multipartRequest([serialized], controller, settings.headers)
         )
       })
       const data = await res.json()

src/dht/put.js

@@ -28,7 +28,7 @@ export const createPut = configure(api => {
         ...options
       }),
       ...(
-        await multipartRequest(value, controller, options.headers)
+        await multipartRequest([value], controller, options.headers)
       )
     })
 

src/files/write.js

@@ -29,12 +29,12 @@ export const createWrite = configure(api => {
         ...options
       }),
       ...(
-        await multipartRequest({
+        await multipartRequest([{
           content: input,
           path: 'arg',
           mode: modeToString(options.mode),
           mtime: parseMtime(options.mtime)
-        }, controller, options.headers)
+        }], controller, options.headers)
       )
     })
 

src/object/patch/append-data.js

@@ -26,7 +26,7 @@ export const createAppendData = configure(api => {
         ...options
       }),
       ...(
-        await multipartRequest(data, controller, options.headers)
+        await multipartRequest([data], controller, options.headers)
       )
     })
 

src/object/patch/set-data.js

@@ -28,7 +28,7 @@ export const createSetData = configure(api => {
         ...options
       }),
       ...(
-        await multipartRequest(data, controller, options.headers)
+        await multipartRequest([data], controller, options.headers)
       )
     })
 

src/pubsub/publish.js

@@ -27,7 +27,7 @@ export const createPublish = configure(api => {
       signal,
       searchParams,
       ...(
-        await multipartRequest(data, controller, options.headers)
+        await multipartRequest([data], controller, options.headers)
       )
     })