Rework tags and flags passing in Makefile

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>

Makefile

@@ -3,19 +3,28 @@ IPFS_MIN_GO_VERSION = 1.7
 IPFS_MIN_GX_VERSION = 0.6
 IPFS_MIN_GX_GO_VERSION = 1.1
 
+GOTAGS =
+GOTAGS += "" # we have to have always at least one tag, empty tag works well
+
+GOFLAGS =
+GOTFLAGS =
 
 export IPFS_REUSEPORT=false
+export GOFLAGS
+export GOTFLAGS
+
+GOFLAGS += -tags $(call join-with,$(comma),$(GOTAGS))
 
 ifneq ($(COVERALLS_TOKEN), )
   covertools_rule = covertools
-  GOT = overalls -project=github.com/ipfs/go-ipfs -covermode atomic -ignore=.git,Godeps,thirdparty,test,core/commands,cmd -- $(GOTFLAGS)
+  GOT = overalls -project=github.com/ipfs/go-ipfs -covermode atomic -ignore=.git,Godeps,thirdparty,test,core/commands,cmd -- $(GOFLAGS) $(GOTFLAGS)
 else
-  covertools_rule = $()
-  GOT = go test $(GOTFLAGS) ./...
+  covertools_rule =
+  GOT = go test $(GOFLAGS) $(GOTFLAGS) ./...
 endif
 
 ifeq ($(TEST_NO_FUSE),1)
-  GOTFLAGS += -tags nofuse
+  GOTAGS += nofuse
 endif
 
 ifeq ($(OS),Windows_NT)
@@ -28,6 +37,13 @@ dist_root=/ipfs/QmNZL8wNsvAGdVYr8uGeUE9aGfHjFpHegAWywQFEdSaJbp
 gx_bin=bin/gx-v0.9.0
 gx-go_bin=bin/gx-go-v1.3.0
 
+
+# util functions
+
+space =
+space +=
+comma =,
+join-with = $(subst $(space),$1,$(strip $2))
 # use things in our bin before any other system binaries
 export PATH := bin:$(PATH)
 export IPFS_API ?= v04x.ipfs.io
@@ -58,7 +74,7 @@ path_check:
 	@bin/check_go_path $(realpath $(shell pwd)) $(realpath $(addsuffix /src/github.com/ipfs/go-ipfs,$(subst $(GOPATH_DELIMITER), ,$(GOPATH))))
 
 deps: go_check gx_check path_check $(covertools_rule)
-	${gx_bin} --verbose install --global
+	${gx_bin} --verbose install --global >/dev/null 2>&1
 
 covertools:
 	go get -u github.com/mattn/goveralls
@@ -71,7 +87,11 @@ covertools:
 vendor: godep
 	godep save -r ./...
 
-install build nofuse: deps
+nofuse: GOTAGS += nofuse
+nofuse: deps
+	$(MAKE) -C cmd/ipfs install
+
+install build: deps
 	$(MAKE) -C cmd/ipfs $@
 
 clean:

cmd/ipfs/Makefile

@@ -1,19 +1,16 @@
 COMMIT := $(shell git rev-parse --short HEAD)
-ldflags = "-X "github.com/ipfs/go-ipfs/repo/config".CurrentCommit=$(COMMIT)"
+GOFLAGS += -ldflags="-X "github.com/ipfs/go-ipfs/repo/config".CurrentCommit=$(COMMIT)"
 
 all: install
 
 install:
-	go install -ldflags=$(ldflags)
+	go install $(GOFLAGS)
 
 build:
-	go build -i -ldflags=$(ldflags)
-
-nofuse:
-	go install -tags nofuse -ldflags=$(ldflags)
+	go build -i $(GOFLAGS)
 
 clean:
-	go clean -ldflags=$(ldflags)
+	go clean $(GOFLAGS)
 
 uninstall:
-	go clean -i -ldflags=$(ldflags)
+	go clean -i $(GOFLAGS)