Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treat security concerns seriously #92

Closed
jbenet opened this issue Sep 20, 2014 · 2 comments
Closed

treat security concerns seriously #92

jbenet opened this issue Sep 20, 2014 · 2 comments

Comments

@jbenet
Copy link
Member

jbenet commented Sep 20, 2014

the codebase had this comment:

    // pretend to encrypt key, then store it unencrypted
    skbytes, err := sk.Bytes()
    if err != nil {
        return err
    }
    cfg.Identity.PrivKey = base64.StdEncoding.EncodeToString(skbytes)

Right now we're cutting a lot of corners and doing things not securely yet. But it's important to flag them as such for people who might be just browsing the codebase. If I saw that on a random codebase i'd be alarmed, even knowing the code is changing.

jbenet added a commit that referenced this issue Sep 20, 2014
@jbenet jbenet closed this as completed Sep 20, 2014
@btc
Copy link
Contributor

btc commented Sep 20, 2014

+:100:

  • leaving explicit TODOs and FIXMEs

@whyrusleeping
Copy link
Member

woops..... +1

jbenet added a commit that referenced this issue Sep 22, 2014
@aschmahmann aschmahmann mentioned this issue Sep 22, 2020
72 tasks
@aschmahmann aschmahmann mentioned this issue Feb 18, 2021
73 tasks
@aschmahmann aschmahmann mentioned this issue Dec 1, 2021
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants