feat: support optional pin names #10261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
requested changes
Dec 15, 2023
hacdias
force-pushed
the
pin-labels
branch
2 times, most recently
from
79c90b7
to
fec88d8
Compare
lidel
changed the title
lidel
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
@hacdias thank you, I've tested locally, added JSON tests (/api/v0 wire format and --enc=json) and some --help text.
I think this is good to go, as long you address cosmetics:
-
see if we can makepins: allow 'ipfs pin add --name' to override name #10277ipfs pin add --nameupdate name of pre-existing pin (if too involved, let's ship as-is) - rename
pin ls --detailedtopin ls --names(but also ok to ignore this suggestion if you feel detailed is better ux)
core/commands/pin/pin.go
Outdated
Comment on lines
72
to
74
| - Pin add is idempotent: pinning CID which is already pinned won't change | ||
| the name, value passed with '--name' with the original pin is preserved. | ||
| To rename pin, use 'pin rm' and 'pin add --name'. |
There was a problem hiding this comment.
@hacdias I've added this because running ipfs pin add --name A CID and then ipfs pin add --name B CID does not update the name (it is still A).
If you feel we could get follow-up calls update the name withoiut huge refactor, that would be preferable, and we could remove this awkward caveat sentence.
|
@lidel I updated to |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4586. Requires ipfs/boxo#525.
A name will apply to all CIDs being pinned. So if you
ipfs pin add --label A [CID1] [CID2] [...], all CIDs will have label "A".