Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "perf(mux) use RWMutex" #219

Merged
merged 1 commit into from
Oct 28, 2014
Merged

Revert "perf(mux) use RWMutex" #219

merged 1 commit into from
Oct 28, 2014

Conversation

btc
Copy link
Contributor

@btc btc commented Oct 28, 2014

Reverts #218

@whyrusleeping points out

RWMutexes Standard lock operation takes twice as long as a normal mutex. The only proper use case for it is frequent reads with infrequent writes, GetBandwidth will be called rather infrequently.

@btc btc added the status/in-progress In progress label Oct 28, 2014
btc pushed a commit that referenced this pull request Oct 28, 2014
Merge pull request #219 from jbenet/revert-218-fix/2014-10-29-mux-rwm…
e8ec8ce 
…utex

Revert "perf(mux) use RWMutex"
@btc btc merged commit e8ec8ce into master Oct 28, 2014
@btc btc removed the status/in-progress In progress label Oct 28, 2014
@btc btc mentioned this pull request Oct 28, 2014
Merged
@btc btc deleted the revert-218-fix/2014-10-29-mux-rwmutex branch October 28, 2014 04:57
@btc btc restored the revert-218-fix/2014-10-29-mux-rwmutex branch October 28, 2014 09:34
@btc btc deleted the revert-218-fix/2014-10-29-mux-rwmutex branch October 28, 2014 09:34
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Oct 23, 2021
@Stebalien
Merge pull request ipfs#219 from libp2p/fix/dht-query-hang
627b5f9 
fix a potential DHT query hang
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
Closed
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@btc