Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dagwriter: fix reuse of buffers problem. #243

Closed
wants to merge 1 commit into from
Closed

dagwriter: fix reuse of buffers problem. #243

wants to merge 1 commit into from

Commits on Oct 30, 2014

  1. dagwriter: fix reuse of buffers problem. 

    The buffers from the client were getting reused (not copied)
and so the data got duplicated internally. The tests don't
catch this!! I tested manually by adding a large text (aeneid).
We should make a test for it.

And, FWIW, tried making the channel sync (i.e. dagwriter
splChan not be buffered), which may be the right way to fix
the problem, but didnt work.
    @jbenet
    jbenet committed Oct 30, 2014
    Configuration menu
    Copy the full SHA
    9917d0a View commit details
    Browse the repository at this point in the history