Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISSUE_TEMPLATE.md #2786

Merged
merged 1 commit into from
Jun 23, 2016
Merged

Add ISSUE_TEMPLATE.md #2786

merged 1 commit into from
Jun 23, 2016

Conversation

chriscool
Copy link
Contributor

This addresses issue #2770.

@Kubuxu
Copy link
Member

Kubuxu commented Jun 1, 2016

In my opinion we shouldn't be using headers to note informations. It will get a bit annoying.

Also there was talk about adding note at the bottom that is information about that go-ipfs repo is about bug reports and directly actionable features. More complex feature requests and general questions should go into different repos.

@chriscool
Copy link
Contributor Author

There are no headers any more. About the note at the bottom, I think it could get annoying too. Isn't there another place where we could tell that?

@Kubuxu
Copy link
Member

Kubuxu commented Jun 1, 2016

No, it is the best we have came up with (as a fix for big number of non-actionable issues in the repo). I would place it at the bottom with something like:

---------------------------------------------------
Please read and then delete
go-ipfs issue tracker ....
If that doesn't fit your issue you might want to use one of following repos:
https://github.com/ipfs/notes/isssues - for general notes and ideas
https://github.com/ipfs/faq/issues - for questions
https://github.com/ipfs/specs/issues - for protocol discussions
etc.

@chriscool
Copy link
Contributor Author

Ok, here is a version close to what you suggest.

It seems a bit verbose to me though. Couldn't we just provide one link from where the user could get more information about the appropriate places?

@Kubuxu
Copy link
Member

Kubuxu commented Jun 1, 2016

This might be a good idea. A central hub to redirect peoples' issues (also this etc. isn't needed in the text itself).

@whyrusleeping what do you think?

@chriscool
Copy link
Contributor Author

etc. has been removed.

We could better detail where issues should be reported here for example:

https://github.com/ipfs/community/blob/master/contributing.md#reporting-issues

@Kubuxu
Copy link
Member

Kubuxu commented Jun 1, 2016

Yeah, this section needs improvements as well.

I would go with what we've got here (thanks) and possibly improve it in future.

@@ -0,0 +1,16 @@
Operating system version & Platform:
IPFS commit version (from `ipfs version --commit`):
IPFS repo version (from `ipfs version --repo`):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the repo version, if we know the commit, or even just the general semver we can infer it. It might be better to ask for 'ipfs version (and commit, if known)'

@whyrusleeping
Copy link
Member

cc @em-ly

@em-ly
Copy link

em-ly commented Jun 1, 2016

Thanks @whyrusleeping. We met today and created some prelimary template outline for the Issues template for https://github.com/ipfs/go-ipfs/

Type:
    bug
    Meta
    question
    test failure
    panic (severe bug)
    enhancement 

Platform:
    Linux
    Windows
    Mac
    Etc.

Processor:
    32
    64
    Arm

Area:
    api
    bandwidth reduction
    bit swap
    blockstore
    commands
    containers + vms
    core
    daemon + init
    dat
    discovery
    encryption
    files
    fuse
    gateway
    interior
    pins
    libp2p
    merkledag
    nat
    releases
    repo
    routing
    tools
    tracking
    unix vs dag

Priority:
    P0 - Operations Functioning
    P1 - Operations Sort of Functioning
    P2 - Operations Not Functioning
    P3 - Operations Foobar (ciritical bug affecting master)
    P4 - Operations on Fire (critical bug affecting release)

Anything else need to be included?

@chriscool
Copy link
Contributor Author

With PR #2790 the versions/platform/processor can be dealt with using ipfs version --all.

@em-ly I am not sure how it is possible, without being very verbose, to ask someone reporting an issue to select the Type, Area and Priority as per the above in a issue template.

Or do you mean that we should have something like:

Version/Platform/Processor information (from `ipfs version --all`):


Type (bug, feature, meta, test failure, question):
Area (api, commands, daemon, fuse, etc):
Priority (from P0: functioning, to P4: operations on fire):

Description:


---------------------------------------------------
Please read and then delete
This is for is for bug reports and directly actionable features only.
Check [where to report an issue](link) if that doesn't fit.
Check [how to report an issue](link) if you are not sure how to fill this issue. 

and the "how to report an issue" linked document would show all the possible values for the Type, Area and Priority fields?

@Kubuxu
Copy link
Member

Kubuxu commented Jun 2, 2016

@chriscool for me it looks great. Only think is that we don't (and shouldn't) use markdown formatting for links as people will see the template mostly in the raw form.



---------------------------------------------------
Please read and then delete
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This is for you! Please read, and then delete this text before posting it."

@RichardLitt
Copy link
Member

What about linking to support? What is ipfs/support for, then?

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@chriscool
Copy link
Contributor Author

chriscool commented Jun 2, 2016

@RichardLitt @em-ly and @Kubuxu here is a new version that tries to take into account what you suggested.

Anyway before this can be merged we need at least the following:

And yeah perhaps we could also add a link to ipfs/support too.

@RichardLitt
Copy link
Member

Made this: ipfs/community#128

Agreed about making a "How to report an issue" for go-ipfs specifically. Happy to do that.

@whyrusleeping
Copy link
Member

The information should be best effort by the user, we can correct and fill stuff in post-filing as we see fit

@chriscool
Copy link
Contributor Author

@RichardLitt thanks for ipfs/community#128!
And yeah, it looks like the only thing left before we can merge this is making a "How to report an issue" for go-ipfs specifically using what @em-ly posted above. Thanks!

@RichardLitt
Copy link
Member

I'm off hiking for a week, but happy to do this when I get back.

@RichardLitt
Copy link
Member

And back. Will be addressing this this week.

@Kubuxu Kubuxu added the topic/meta Topic meta label Jun 13, 2016
@whyrusleeping whyrusleeping added this to the Ipfs 0.4.3 milestone Jun 21, 2016
@whyrusleeping
Copy link
Member

@RichardLitt @em-ly update here?

@em-ly
Copy link

em-ly commented Jun 22, 2016

@RichardLitt is going to work on getting this completed for this week!
Thanks for bumping the issue.

On Tue, Jun 21, 2016 at 12:57 PM, Jeromy Johnson notifications@github.com
wrote:

@RichardLitt https://github.com/RichardLitt @em-ly
https://github.com/em-ly update here?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2786 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ASplmmRBWMdCcvLhZRDSDLqFO6B-l_s3ks5qOBflgaJpZM4Ir26U
.

Emily Moore
Project Manager
Protocol Labs, Inc.

RichardLitt added a commit that referenced this pull request Jun 22, 2016
See #2786

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
@RichardLitt
Copy link
Member

Created #2889. This should be good to go, now?

@RichardLitt RichardLitt added the need/review Needs a review label Jun 22, 2016
@chriscool
Copy link
Contributor Author

Yeah, when PR #2889 is merged, I will update this and it should be good to go.

@Kubuxu
Copy link
Member

Kubuxu commented Jun 22, 2016

I would do something like:


Version information:

please run and copy here the result of: ipfs version -all

RichardLitt added a commit that referenced this pull request Jun 22, 2016
See #2786

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt added a commit that referenced this pull request Jun 22, 2016
See #2786

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt added a commit that referenced this pull request Jun 22, 2016
See #2786

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
@whyrusleeping
Copy link
Member

#2889 is merged!

@RichardLitt
Copy link
Member

LGTM. Let's try it!

@whyrusleeping
Copy link
Member

is this RFM?

@em-ly
Copy link

em-ly commented Jun 23, 2016

LGTM! Thanks for all the work on this @chriscool @RichardLitt and @Kubuxu! Let's roll this out and test it throughout the week, edits made as necessary.

@whyrusleeping whyrusleeping merged commit 0ac81da into master Jun 23, 2016
@whyrusleeping whyrusleeping deleted the issue-template branch June 23, 2016 00:56
@whyrusleeping
Copy link
Member

Feedback time, I think we need to use something much more minimal, there is too much text in the template and its a bit overwhelming to users who most of the time won't have any idea what half of it means. I propose something closer to:

[//]: # (Output From `ipfs version --all`)
- Version Information: 

[//]: # ( Bug, Feature, Enhancement, Etc )
- Type:

[//]: # ( from `P0` "Critical" to `P5` "Relatively Unimportant")
- Priority :

### Description:

Using a bit of a hack for markdown comments that the user will see when creating the issue, but that wont render when the issue itself is viewed.

@RichardLitt
Copy link
Member

RichardLitt commented Aug 4, 2016

Looks very good to me!

@dignifiedquire
Copy link
Member

I just discovered you can use html comments in these, take a look at the template from nodejs/node: https://raw.githubusercontent.com/nodejs/node/master/.github/ISSUE_TEMPLATE.md

These templates also seem to be quite useful and working

@whyrusleeping
Copy link
Member

@dignifiedquire oooooh, good find! I like that a little better than the empty link hovertext hack i'm using

@RichardLitt
Copy link
Member

Also worth taking into account: the repos in this repository: https://github.com/devspace/awesome-github-templates

@jbenet
Copy link
Member

jbenet commented Aug 27, 2016

The current issue template is a bit cumbersome. maybe it's just how the formatting works. consider these that @RichardLitt posted: https://github.com/devspace/awesome-github-templates and how they do it. headings may be a good way to ask questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review topic/meta Topic meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants