Add way to check if node is online or offline #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there was no sure way to check if node is in online or offline mode. License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxu
changed the title
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxu
force-pushed
the
feature/api-offline
branch
from
245e8fa
to
c10ed85
Compare
|
LGTM |
|
@Kubuxu changed the API in what way? this type of thing is important to put directly into the commit messages, not just the PR, and to be very explicit about what, to be super clear with everyone. cc @whyrusleeping too about this. |
|
(i think it just added a feature, but just checking) |
|
Yes, it is just an added feature, we are pining Richard like that to notify him that this PR includes something that requires update in http-api-spec. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @lgierth.
@RichardLitt this changes API.