Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc/cmds/log notice unused #3160

Merged
merged 3 commits into from
Sep 7, 2016
Merged

Doc/cmds/log notice unused #3160

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8663b4d
Remove notice from list of log levels.
JesseWeinstein Aug 31, 2016
9304cf1
Clarify distinction between event and other logging
JesseWeinstein Aug 31, 2016
fab7ad8
Reduce vehemence of help text, per PR comments
JesseWeinstein Sep 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions core/commands/log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ var logLevelCmd = &cmds.Command{
Helptext: cmds.HelpText{
Tagline: "Change the logging level.",
ShortDescription: `
'ipfs log level' is a utility command used to change the logging
output of a running daemon.
Change the verbosity of one or all subsystems log output. Does NOT affect the event log.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change NOT to not. It says it without needing to draw attention to it. Also, This does not... is better, I think.

`,
},

Expand All @@ -45,7 +44,7 @@ output of a running daemon.
// clash with a subsystem name
cmds.StringArg("subsystem", true, false, fmt.Sprintf("The subsystem logging identifier. Use '%s' for all subsystems.", logAllKeyword)),
cmds.StringArg("level", true, false, `The log level, with 'debug' the most verbose and 'critical' the least verbose.
One of: debug, info, notice, warning, error, critical.
One of: debug, info, warning, error, critical.
`),
},
Run: func(req cmds.Request, res cmds.Response) {
Expand Down Expand Up @@ -91,9 +90,9 @@ subsystems of a running daemon.

var logTailCmd = &cmds.Command{
Helptext: cmds.HelpText{
Tagline: "Read the logs.",
Tagline: "Read the event log.",
ShortDescription: `
'ipfs log tail' is a utility command used to read log output as it is written.
Outputs event log messages (NOT other log messages) as they are generated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, NOT to not.

`,
},

Expand Down