commands/files: use new cmds #5665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overbool
force-pushed
the
refactor/commands/files
branch
from
5df69a8
to
b01375c
Compare
magik6k
reviewed
Oct 29, 2018
|
@magik6k Fixed it. |
overbool
force-pushed
the
refactor/commands/files
branch
from
67c4e2d
to
07f3a1f
Compare
kevina
approved these changes
Oct 31, 2018
| return | ||
| } | ||
| } | ||
| }() |
There was a problem hiding this comment.
👍 for the removal of the defer, it isn't really needed and the logic is simpler now.
magik6k
approved these changes
Nov 1, 2018
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
Stebalien
force-pushed
the
refactor/commands/files
branch
from
07f3a1f
to
f37553f
Compare
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer: #5664
License: MIT
Signed-off-by: Overbool overbool.xu@gmail.com