Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove timeout on default DHT operations #9783

Merged
merged 2 commits into from
Mar 30, 2023
Merged

fix: remove timeout on default DHT operations #9783

merged 2 commits into from
Mar 30, 2023

Commits on Mar 30, 2023

  1. fix: remove timeout on default DHT operations 

    This removes the timeout by default for DHT operations. In particular
this causes issues with ProvideMany requests which can take an
indeterminate amount of time, but really these should just respect
context timeouts by default. Users can still specify timeouts here if
they want, but by default they will be set to "0" which means "no
timeout".

This is unlikely to break existing users of custom routing, because
there was previously no utility in configuring a router with timeout=0
because that would cause the router to immediately fail, so it is
unlikely (and incorrect) if anybody was using timeout=0.
    @guseggert
    guseggert committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    5fda291 View commit details
    Browse the repository at this point in the history

  2. fix: remove 5m timeout on ProvideManyRouter 

    For context see
5fda291
    @lidel
    lidel committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    e395de9 View commit details
    Browse the repository at this point in the history