Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: some updates to #92 #109

Merged
merged 8 commits into from
Mar 14, 2024
Merged

feat: some updates to #92 #109

merged 8 commits into from
Mar 14, 2024

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Mar 14, 2024

minor code cleanup and improvements for #92

  • chore: PR comments and minor improvements
  • fix: use sw-cache-expires
  • chore: cleanup hasExpired return
  • chore: log on cache miss
  • chore: wait for response so we can cache it
  • chore: minor cleanup
  • chore: minor cleanup
  • fix: stale-while-revalidate for ipns

notable changes:

  1. stale-while-revalidate only for IPNS content (if people want no network requests, query ipfs resource)
  2. sw-cache-expires as called out by @2color
  3. consolidation of fetch + update cache in fetchAndUpdateCache function

@SgtPooki SgtPooki mentioned this pull request Mar 14, 2024
3 tasks
@SgtPooki SgtPooki requested review from 2color and lidel March 14, 2024 00:49
Copy link
Member

@2color 2color left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks for the polish

@2color 2color merged commit c08c467 into add-cache Mar 14, 2024
20 checks passed
@2color 2color deleted the feat/add-cache-patch branch March 14, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants