Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a CARv2 SelectiveCARAPI when clients have upgraded to go-ipld-prime v0.9.0 #104

Closed
aarshkshah1992 opened this issue Jun 24, 2021 · 1 comment
Closed

Implement a CARv2 SelectiveCARAPI when clients have upgraded to go-ipld-prime v0.9.0 #104

aarshkshah1992 opened this issue Jun 24, 2021 · 1 comment
Labels
P3 Low: Not priority right now

Comments

@aarshkshah1992
Copy link
Contributor

aarshkshah1992 commented Jun 24, 2021 •
edited
Loading

#102 removes the CARv1 dependency from the WIP CARv2 library and states the motivation for doing so i.e. to not force clients to upgrade to the breaking go-ipld-prime v0.9.0 release because the latest CARv1 release depends on go-ipld-prime v0.9.0.

Towards that goal, the CARv2 library also holds back from implementing a SelectiveCAR API for v2 as the SelectiveCAR implementation would need go-ipld-prime and we should be using the latest ipld prime release i.e. go-ipld-prime v0.9.0 to implement it rather than using an older IPLD prime release.

This issue is meant to capture the fact that we should implementing a CARv2 SelectiveCAR API when clients have upgraded to go-ipld-prime v0.9.0.
@aarshkshah1992 aarshkshah1992 changed the title Implement a CARv2 Selective CAR API when clients have upgraded to go-ipld-prime v0.9.0 Implement a CARv2 SelectiveCARAPI when clients have upgraded to go-ipld-prime v0.9.0 Jun 24, 2021
@mvdan mvdan mentioned this issue Jun 29, 2021
Closed
@masih masih added the P3 Low: Not priority right now label Jul 6, 2021
@masih masih modified the milestone: CAR v2 Jul 6, 2021
This was referenced Jul 9, 2021
Closed
Merged
masih added a commit that referenced this issue Jul 23, 2021
@masih
Add zero-length sections as EOF option to internal CARv1 reader
231a824 
The CARv2 implementation uses an internal fork of CARv1 due to upstream
dependency issues captured in #104. Propagate the options set in CARv2
APIs for treatment of zero-lenth sections onto internal packages so that
APIs using the internal CARv1 reader behave consistently. Use a `bool`
for setting the option, since it is the only option needed in CARv1.

Update tests to reflect changes.

Add additional tests to internal CARv1 package and ReadOnly blockstore
that assert option is propagated.

Fixes #190
@masih masih mentioned this issue Jul 23, 2021
Merged
masih added a commit that referenced this issue Jul 23, 2021
@masih
Add zero-length sections as EOF option to internal CARv1 reader
703b88c 
The CARv2 implementation uses an internal fork of CARv1 due to upstream
dependency issues captured in #104. Propagate the options set in CARv2
APIs for treatment of zero-lenth sections onto internal packages so that
APIs using the internal CARv1 reader behave consistently. Use a `bool`
for setting the option, since it is the only option needed in CARv1.

Update tests to reflect changes.

Add additional tests to internal CARv1 package and ReadOnly blockstore
that assert option is propagated.

Fixes #190
@masih
Copy link
Member

masih commented Dec 15, 2021

Fixed by #269

@masih masih closed this as completed Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 Low: Not priority right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@masih @aarshkshah1992