Unify utility Reader/Writer types into internalio
#145
Comments
This was referenced Jul 13, 2021
masih
added a commit
that referenced
this issue
Jul 15, 2021
Implement the ability to generate index from a CARv1 payload given only an `io.Reader`, where the previous implementation required `io.ReadSeeker`. The rationale is to be minimal in what we expect in the API, since index generation from a CARv1 payload never need to rewind the reader and only moves forward in the stream. Refactor utility IO functions that convert between types in one place. Implement constructor functions that only instantiate wrappers when the passed argument does not satisfy a required interface. Fixes: - #146 Relates to: - #145
|
Resolved by #173 |
mvdan
pushed a commit
that referenced
this issue
Jul 16, 2021
Improve reader type conversion by checking if type satisfies ReaderAt to avoid unnecessary wrapping. Move io converters into one place. Fixes: - #145
|
Merged. |
mvdan
pushed a commit
that referenced
this issue
Jul 16, 2021
Implement the ability to generate index from a CARv1 payload given only an `io.Reader`, where the previous implementation required `io.ReadSeeker`. The rationale is to be minimal in what we expect in the API, since index generation from a CARv1 payload never need to rewind the reader and only moves forward in the stream. Refactor utility IO functions that convert between types in one place. Implement constructor functions that only instantiate wrappers when the passed argument does not satisfy a required interface. Fixes: - #146 Relates to: - #145
mvdan
pushed a commit
that referenced
this issue
Jul 16, 2021
Improve reader type conversion by checking if type satisfies ReaderAt to avoid unnecessary wrapping. Move io converters into one place. Fixes: - #145
Jorropo
pushed a commit
to ipfs/boxo
that referenced
this issue
Mar 22, 2023
Implement the ability to generate index from a CARv1 payload given only an `io.Reader`, where the previous implementation required `io.ReadSeeker`. The rationale is to be minimal in what we expect in the API, since index generation from a CARv1 payload never need to rewind the reader and only moves forward in the stream. Refactor utility IO functions that convert between types in one place. Implement constructor functions that only instantiate wrappers when the passed argument does not satisfy a required interface. Fixes: - ipld/go-car#146 Relates to: - ipld/go-car#145 This commit was moved from ipld/go-car@6b085bc
Jorropo
pushed a commit
to ipfs/boxo
that referenced
this issue
Mar 22, 2023
Improve reader type conversion by checking if type satisfies ReaderAt to avoid unnecessary wrapping. Move io converters into one place. Fixes: - ipld/go-car#145 This commit was moved from ipld/go-car@f3fc595
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
should this live in
internal/io?Originally posted by @willscott in #144 (comment)
The text was updated successfully, but these errors were encountered: