Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to bufio.Reader in internal carv1 package #160

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Remove dependency to bufio.Reader in internal carv1 package #160

merged 1 commit into from
Jul 15, 2021

Commits on Jul 15, 2021

  1. Remove dependency to bufio.Reader in internal carv1 package

    Remove dependency to `bufio.Reader` in internal `carv1` package that
    seems to be mainly used for peeking a byte to return appropriate error
    when stream abruptly ends, relating to #36. This allows simplification
    of code across the repo and remove all unnecessary wrappings of
    `io.Reader` with `bufio.Reader`. This will also aid simplify the
    internal IO utilities which will be done in future PRs. For now we
    simply remove dependency to `bufio.Reader`
    
    See:
    - #36
    masih committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    7439bf5 View commit details
    Browse the repository at this point in the history