Add example blockstore examples #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
force-pushed
the
blockstore-example
branch
2 times, most recently
from
1798caf
to
d9aa434
Compare
mvdan
approved these changes
Jul 16, 2021
v2/blockstore/example_test.go
Outdated
| fmt.Println("List of first 5 CIDs and their raw data size:") | ||
| var i int | ||
| for k := range keysChan { | ||
| if i > 4 { |
There was a problem hiding this comment.
if you want to print 5, I think it's then easier to do i >= 5, to use the same number everywhere. you might as well make that a const/var and use it in the print above
v2/blockstore/example_test.go
Outdated
|
|
||
| // Finalize the blockstore to flush out the index and make a complete CARv2. | ||
| // Note, Finalize must be called on an open ReadWrite blockstore to flush out a complete CARv2. | ||
| if err = resumedRwbos.Finalize(); err != nil { |
There was a problem hiding this comment.
nit: this can be :=; it helps keep the code simpler to follow as you're not modifying the var in the parent scope. this can be done for any other place where you only assign an error.
masih
force-pushed
the
blockstore-example
branch
from
d9aa434
to
a4cebbe
Compare
Implement examples that show how to open a read-only blockstore, and a read-write blockstore along with resumption from the same file. The example surfaced a race condition where if the `AllKeysChan` is partially consumed and file is closed then the gorutie started by chan population causes the race condition. Locking on Close will make the closure hang. Better solution is needed but choices are limited due to `AllKeysChan` signature. Fixes: - #124
masih
force-pushed
the
blockstore-example
branch
from
48b7928
to
0c606f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement examples that show how to open a read-only blockstore, and a
read-write blockstore along with resumption from the same file.
Fixes: