Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test script for car verify #236

Merged
merged 4 commits into from
Sep 15, 2021
Merged

Add test script for car verify #236

merged 4 commits into from
Sep 15, 2021

Conversation

willscott
Copy link
Member

No description provided.

Copy link
Contributor

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM assuming verify prints nothing when it's happy

@willscott
Copy link
Member Author

Not to expand scope too much, but here's also a commit to test the filter command.

@willscott
Copy link
Member Author

I feel a bit dirty about the need for windows specific line endings. I guess the alternative is that i'd need to have the test figure file embedded in filter.txt split into a separate file, maybe?

@mvdan
Copy link
Contributor

mvdan commented Sep 15, 2021

It's best to just not let git convert plaintext files to CRLF: https://github.com/mvdan/sh/blob/master/.gitattributes

@willscott
Copy link
Member Author

It's best to just not let git convert plaintext files to CRLF: https://github.com/mvdan/sh/blob/master/.gitattributes

That appears to have worked 👍

@willscott willscott merged commit c8572be into master Sep 15, 2021
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants