Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

fix: create buffers from decoded multihash digests #287

Merged
merged 2 commits into from
Aug 5, 2020

Conversation

achingbrain
Copy link
Member

multihash.decode returns Uint8Arrays which we set as prevHash
but bitcoin-lib requires these to be node Buffers.

`multihash.decode` returns Uint8Arrays which we set as `prevHash`
but bitcoin-lib requires these to be node Buffers.
@achingbrain achingbrain requested a review from vmx August 5, 2020 09:39
@achingbrain
Copy link
Member Author

N.b. browser tests are failing due to babel/babel#11914

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #287 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   88.31%   88.23%   -0.08%     
==========================================
  Files           3        3              
  Lines         154      153       -1     
==========================================
- Hits          136      135       -1     
  Misses         18       18              
Impacted Files Coverage Δ
src/index.js 86.76% <ø> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75037ea...08105ef. Read the comment docs.

@vmx vmx merged commit 28ecc2f into master Aug 5, 2020
@vmx vmx deleted the fix/create-bufffers-from-decoded-multihashes branch August 5, 2020 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants