Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot use absolute path in ReadExtractor #75

Open
jinyung opened this issue Nov 23, 2021 · 1 comment
Open

cannot use absolute path in ReadExtractor #75

jinyung opened this issue Nov 23, 2021 · 1 comment

Comments

@jinyung
Copy link

jinyung commented Nov 23, 2021

Hi Inigo,

I think this is inconvenient to users used to using absolute path in their script:

raw_bam = ps.AlignmentFile(self.working_dir + "/" + self.sorted_bam, "rb")

circle_sv_reads = ps.AlignmentFile(self.working_dir + "/" + self.output_bam , "wb", template=raw_bam)

Best regards
JY

@iprada
Copy link
Owner

iprada commented Nov 23, 2021

Dear @jinyung,

You are absolutely right. I wish 6 years ago Inigo was a better programmer.

Right now I am busy with other projects, and have limited time to dig into this. Would you be up for making a pull request?

I'll gladly accept one!

JiguangPeng added a commit to JiguangPeng/Circle-Map that referenced this issue Jun 15, 2022
iprada added a commit that referenced this issue Jul 2, 2022
[#75] ReadExtractor support absolute path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants