Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop NEO support? #18

Closed
tarcieri opened this issue Nov 25, 2019 · 2 comments
Closed

Drop NEO support? #18

tarcieri opened this issue Nov 25, 2019 · 2 comments

Comments

@tarcieri
Copy link
Collaborator

It seems like there's a lot of complexity in the codebase to support pre-YubiKey 4 devices (a.k.a. YubiKey NEO).

I'm wondering if these are sufficiently old at this point (and have multiple known vulnerabilities, IIRC) to where it would make sense to make this library only support YK4 and YK5.
@tarcieri tarcieri added the question Further information is requested label Nov 25, 2019
@tarcieri
Copy link
Collaborator Author

Most notably, this affects the calculation of buffer sizes for objects being sent to/from the card, which is particularly tricky as it needs to be passed to things which are borrowing &mut YubiKey, so it has to happen in advance before the transaction is open, and passed as a parameter.

tarcieri added a commit that referenced this issue Dec 7, 2019
@tarcieri
Merge pull request #63 from iqlusioninc/drop-neo-support
509c438 
Drop YubiKey NEO support (closes #18)
@tarcieri
Copy link
Collaborator Author

tarcieri commented Dec 7, 2019

NEO support was dropped in #63

@tarcieri tarcieri removed the question Further information is requested label Dec 9, 2019
@str4d str4d mentioned this issue Jan 4, 2023
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tarcieri