Add vm.buffer.hash and util.buffer.hash ops #16003
Conversation
qedawkins
force-pushed
the
buffer_hash
branch
from
6244ba3
to
2ad9136
Compare
This adds support for computing the SipHash24 of a byte range of a buffer, with the goal of using this as a primitive for building a hash table out of VM IR.
There was a problem hiding this comment.
Minor style nits and such,
It'd be nice to know how we could make this incremental (an optional state buffer, etc) but that can come with some larger crypto module that does more stuff than what this is intended for (basic hashing of simple bytes spans). Keeping it simple here means we can optimize it pretty tightly/port it pretty easily!
compiler/src/iree/compiler/Dialect/Util/IR/test/buffer_ops.mlir
Outdated
Show resolved
Hide resolved
I found this investigation of a few different choices for incremental hash functions so maybe we can import learnings from there: rust-lang/rust#41215 |
This adds support for computing the SipHash24 of a byte range of a buffer, with the goal of using this as a primitive for building a hash table out of VM IR.