Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade brace-expansion to version 1.1.7 or later. #106

Closed
adma opened this issue Apr 26, 2017 · 2 comments
Closed

Upgrade brace-expansion to version 1.1.7 or later. #106

adma opened this issue Apr 26, 2017 · 2 comments

Comments

@adma
Copy link

adma commented Apr 26, 2017

brace-expansion is a module to support bash-like brace expansion in JavaScript. For example,{1,2,3,4} would expand to 1 2 3 4. brace expansion versions before 1.1.7 are vulnerable to Regular Expression Denial of Service attacks. A proof of concept is provided below:

var expand = require('brace-expansion');
expand('{,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,

references:
juliangruber/brace-expansion#33
https://github.com/juliangruber/brace-expansion/pull/35/files

@plynchnlm
Copy link

Minimatch 3.0.3 already specifies:

"brace-expansion": "^1.0.0"

so it should pick up the new version. Do "npm uninstall brace-expansion" and reinstall.

@dylansmith
Copy link

dylansmith commented May 7, 2017

This was actually recently updated and merged in #107 (published as minimatch@3.0.4). This should be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants