Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(README): add #anchor and improve notes #591

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(README): add #anchor and improve notes #591

wants to merge 1 commit into from

Conversation

danielbayley
Copy link

@danielbayley danielbayley commented Jun 25, 2024 •
edited

Just some quick improvements to navigation and readability…

@danielbayley danielbayley force-pushed the patch-1 branch 22 times, most recently from 763b325 to 3f7940c Compare June 25, 2024 01:26
isaacs
isaacs requested changes Jun 25, 2024
View reviewed changes
Copy link
Owner

@isaacs isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but it shouldn't need   in markdown, should it? What's that about?

@isaacs
Copy link
Owner

isaacs commented Jun 25, 2024

I mean, Lgtm except for the nbsp's

@danielbayley
Copy link
Author

Lgtm, but it shouldn't need   in markdown, should it? What's that about?

Yeah just some weird shit happening with the indentation around using

Note

notes inside of indented lists

I plan on using this new feature in a lot of places, so just trying to figure out how to fix this edge case (I think it’s still in beta…)

I’ll unmark as draft once I’ve either figured it out or given up and sent an email to support 😅

@danielbayley danielbayley marked this pull request as draft June 25, 2024 01:32
@danielbayley danielbayley force-pushed the patch-1 branch 3 times, most recently from 3678d42 to 671b716 Compare June 25, 2024 01:40
@danielbayley danielbayley force-pushed the patch-1 branch 16 times, most recently from c3035e2 to 956fb60 Compare June 25, 2024 02:06
@danielbayley danielbayley requested a review from isaacs June 25, 2024 02:10
@danielbayley danielbayley marked this pull request as ready for review June 25, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6555lee 6555lee 6555lee approved these changes

@isaacs isaacs Awaiting requested review from isaacs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielbayley @isaacs @6555lee