Add ESM version #266
Closed
Add ESM version #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal implementation to provide a native ESM version of the package.
The main idea is that you don't need to have both files in the repository, and can generate the ESM version just before publishing a new version. I added a minimal build script to do that without adding new dependencies. I tested the result on Node (from both CJS and ESM scripts), and on Vite + webpack (both of which consumed the generated ESM file).
In regards to TypeScript: not changes are necessary because the types are the same for CJS and ESM distribution.
Closes #253