Split LICENSE into two files #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, GitHub doesn't automatically recognize tophu's licenses, presumably because the text of both licenses are appened to the `LICENSE` file, causing that file to fail pattern matching. Other dual-licensed software repos (e.g. https://github.com/facebook/buck2) *do* have their licenses recognized by GitHub. The trick seems to be to put the contents of each license in a separate file. This has the minor downside of making the top-level directory slightly more crowded.
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 97.62% 97.62%
=======================================
Files 9 9
Lines 759 759
=======================================
Hits 741 741
Misses 18 18 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, GitHub doesn't automatically recognize tophu's licenses, presumably because the text of both licenses are concatenated in the
LICENSEfile, causing that file to fail pattern matching.However, GitHub does successfully recognize the licenses of other dual-licensed software repos (e.g. https://github.com/facebook/buck2). The trick seems to be to put the contents of each license in a separate file.
This has the minor downside of making the top-level directory slightly more crowded.