Modernize type annotations #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use more modern type annotations as described in [PEP 585](https://peps.python.org/pep-0585) and [PEP 604](https://peps.python.org/pep-0604/). The syntax proposed in these PEPs for Python 3.9 & 3.10 can be enabled in Python>=3.7 using ```python from __future__ import annotations ``` * Replace usage of (deprecated) `typing.Tuple` and `typing.List` with `tuple` and `list` * Replace usage of (deprecated) `typing.Iterable` and `typing.Iterator` with the corresponding classes from `collections.abc` * Use pipe (`|`) operator syntax to avoid usage of `typing.Optional` and `typing.Union` I also removed some awkward custom types (`IntOrInts` and `NDSlice`) and replaced their usage in the code with their literal definitions, which have been simplified by the above changes.
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage 97.62% 97.63%
=======================================
Files 9 9
Lines 759 761 +2
=======================================
+ Hits 741 743 +2
Misses 18 18
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use more modern type annotations as described in PEP 585 and PEP 604. The syntax proposed in these PEPs for Python 3.9 and 3.10 can be enabled in Python>=3.7 using
Changes include:
typing.Tupleandtyping.Listwithtupleandlisttyping.Iterableandtyping.Iteratorwith the corresponding classes fromcollections.abc|) operator syntax to avoid usage oftyping.Optionalandtyping.UnionI also removed some awkward custom types (
IntOrIntsandNDSlice) and replaced their usage in the code with their literal definitions, which have been simplified a bit by the above changes.