Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamics_velocity_NoAir #23

Merged
merged 8 commits into from
May 27, 2024
Merged

Conversation

A-Hayasaka
Copy link
Collaborator

add velocity dynamics for upper stage (without aerodynamics) to improve performance

@A-Hayasaka A-Hayasaka requested a review from sus304 May 21, 2024 14:38
A-Hayasaka and others added 2 commits May 22, 2024 09:24
remove velocity from args of dynamics_velocity_NoAir
sus304
sus304 previously approved these changes May 25, 2024
Copy link

@sus304 sus304 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RP_ORv2_SYS_0044のノミナル軌道で同等の結果が得られることを確認

@A-Hayasaka
Copy link
Collaborator Author

@sus304
改めてコードを確認してみたら、無駄な計算をしている箇所がいくつかあったので、この機会に修正しました。
お手数ですが、もう一度動作チェックお願いできますでしょうか?修正前後で結果は完全に一致するはずです。

Copy link

@sus304 sus304 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

チェック済み。結果の質量、イベント時刻、関数のコール回数まで同一であることを確認。

@A-Hayasaka A-Hayasaka merged commit 37d590b into master May 27, 2024
2 checks passed
@A-Hayasaka A-Hayasaka deleted the add_velocity_equation_noair branch May 27, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants