Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert code, upgrade server #5250

Merged
merged 5 commits into from
May 25, 2024
Merged

fix: revert code, upgrade server #5250

merged 5 commits into from
May 25, 2024

Conversation

yathomasi
Copy link
Contributor

@yathomasi yathomasi commented May 24, 2024

Screenshot 2024-05-24 at 20 30 45 - Enabled Always online for `dvc.org` Screenshot 2024-05-24 at 20 32 17 - Used this opportunity to refactor error handling

Copy link
Contributor

github-actions bot commented May 24, 2024

Link Check Report

There were no links to check!

@yathomasi yathomasi marked this pull request as ready for review May 24, 2024 14:47
@yathomasi yathomasi requested a review from a team as a code owner May 24, 2024 14:47
@yathomasi yathomasi self-assigned this May 24, 2024
package.json Outdated
@@ -44,7 +44,7 @@
},
"dependencies": {
"@dvcorg/gatsby-theme-iterative": "0.3.14",
"@dvcorg/websites-server": "0.1.3",
"@dvcorg/websites-server": "0.2.0-beta.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why beta?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will use new version before merge.

@shcheklein
Copy link
Member

@yathomasi so, why did we have the issue with GH itself though - what was the error Sentry was trying to report about?

@yathomasi
Copy link
Contributor Author

@yathomasi so, why did we have the issue with GH itself though - what was the error Sentry was trying to report about?

It was trying to set headers to tracking outgoing requests, Github api in this case. I feel, it's not required in our project specially in the nodejs side.

@shcheklein
Copy link
Member

It was trying to set headers to tracking outgoing requests, Github api in this case. I feel, it's not required in our project specially in the nodejs side.

kk, I see. thanks.

@yathomasi yathomasi temporarily deployed to dvc-org-upgrade-server-37swrky May 24, 2024 15:45 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-upgrade-server-zkwjecw May 24, 2024 15:45 Inactive
@yathomasi yathomasi had a problem deploying to dvc-org-upgrade-server-zkwjecw May 24, 2024 16:32 Failure
@yathomasi yathomasi temporarily deployed to dvc-org-upgrade-server-zkwjecw May 25, 2024 03:42 Inactive
@yathomasi yathomasi temporarily deployed to dvc-org-upgrade-server-zkwjecw May 25, 2024 04:29 Inactive
@yathomasi yathomasi merged commit 40bb83f into main May 25, 2024
5 checks passed
@yathomasi yathomasi deleted the upgrade-server branch May 25, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants