Adds react-native-windows support for UWP #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset includes most of the react-native-fs functionality working for UWP. Some notable missing features are: * all of the `Assets` APIs (e.g., `readDirAssets`, `existsAssets`, etc.) that are Android specific * the `pathForBundle` and `pathForGroup` APIs that are iOS specific * the `uploadFiles` API, which just has not yet been implemented.
|
@itinance any chance we can get this merged? |
|
Hell yes, thank you :) My issue was that i haven't any windows system here to test it. Since it doesnt effect any existing code for iOS and Android i will merge now. |
|
@rozele Would you mind providing a section in README.md for UWP-support? Thank you! |
|
@itinance of course! I'll try to write something up this week! Thanks for merging! |
|
Great. It would be part then of next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset includes most of the react-native-fs functionality working for UWP. Some notable missing features are:
AssetsAPIs (e.g.,readDirAssets,existsAssets, etc.) that are Android specificpathForBundleandpathForGroupAPIs that are iOS specificuploadFilesAPI, which just has not yet been implemented.