improve error handeling for GithubCommitActivity

The author filter error handling removed was redundent as it would never execute, there is no way to seperate branch not found from repo not found.
jNullj · Jun 14, 2023 · 9e358c8 · 9e358c8
1 parent 6703fe6
commit 9e358c8
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/services/github/github-commit-activity.service.js b/services/github/github-commit-activity.service.js
@@ -136,7 +136,7 @@ export default class GitHubCommitActivity extends GithubAuthV4Service {
           since,
         },
       },
-      errorMessages: errorMessagesFor('repo not found'),
+      errorMessages: errorMessagesFor('repo or branch not found'),
     })
   }
 
@@ -152,11 +152,7 @@ export default class GitHubCommitActivity extends GithubAuthV4Service {
     return repo.history.totalCount
   }
 
-  static transformAuthorFilter({ res, buffer }) {
-    if (buffer.message === 'Not Found') {
-      throw new InvalidResponse({ prettyMessage: 'invalid branch' })
-    }
-
+  static transformAuthorFilter({ res }) {
     const parsed = parseLinkHeader(res.headers.link)
 
     if (!parsed) {