Replace static util class with JarDetails #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
reviewed
Sep 13, 2023
...rc/main/java/io/opentelemetry/instrumentation/javaagent/runtimemetrics/java8/JarDetails.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/opentelemetry/instrumentation/javaagent/runtimemetrics/java8/JarDetails.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/opentelemetry/instrumentation/javaagent/runtimemetrics/java8/JarDetails.java
Outdated
Show resolved
Hide resolved
| * For a given URL representing a Jar directly on the file system or embedded within another | ||
| * archive, this class provides methods which expose useful information about it. | ||
| */ | ||
| class JarDetails { |
There was a problem hiding this comment.
I find the arrangement of all this code into a class with inheritance and where the various extraction bits are distributed across construction and accessors to be harder to reason about than the JarAnalyzerUtil approach, where each extraction task is implemented as a pure function without side affects.
Is there any way to have the best of both worlds? Simple code arrangement and good performance?
There was a problem hiding this comment.
Some of the things could be extracted to a static method, but many of the significant optimizations were unlocked in the overloaded methods. Do you have anything specific in mind?
This class is able to be more optimized by using random access file classes depending on if the jar is embedded within another archive file (eg spring boot, war, ear, etc).
tylerbenson
force-pushed
the
emit-package-events
branch
from
a8073e3
to
100dc45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class is able to be more optimized by using random access file classes depending on if the jar is embedded within another archive file (eg spring boot, war, ear, etc).