Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spell checker to CI #665

Closed
yurishkuro opened this issue Jan 19, 2024 · 2 comments · Fixed by #668
Closed

Add spell checker to CI #665

yurishkuro opened this issue Jan 19, 2024 · 2 comments · Fixed by #668
Labels
good first issue help wanted

Comments

@yurishkuro
Copy link
Member

Something similar to github.com/open-telemetry/opentelemetry-collector/pull/9318
@jaydee029
Copy link

jaydee029 commented Jan 20, 2024 •
edited
Loading

Hi, I would like to work on this.

  • I'm assuming a new ci workflow would be needed, however it can be added into the existing test workflow as well.
  • Also , please mention if there are any constraints such as words or files that may not be spell checked, if you have a list ( if not, I'll be looking into it anyway).

h4shk4t added a commit to h4shk4t/documentation that referenced this issue Feb 1, 2024
@h4shk4t
Add spell checker to test workflow (jaegertracing#665)
b480121
@h4shk4t
Copy link
Contributor

h4shk4t commented Feb 1, 2024

Hi @yurishkuro I would like to work on this issue.

h4shk4t added a commit to h4shk4t/documentation that referenced this issue Feb 1, 2024
@h4shk4t
Add spell checker to test workflow (jaegertracing#665)
fe88c2f
@h4shk4t h4shk4t mentioned this issue Feb 1, 2024
Merged
h4shk4t added a commit to h4shk4t/documentation that referenced this issue Feb 1, 2024
@h4shk4t
Add spell checker to test workflow (jaegertracing#665)
13b9a6a 
Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>
yurishkuro added a commit that referenced this issue Apr 4, 2024
@h4shk4t @yurishkuro
Add Spell Checker to CI (#668)
916ed3a 
## Which problem is this PR solving?
- Closes
[#665](#665)

## Description of the changes
- Simply added a new cspell job to the existing ci-test workflow.
- Will perform the spell check in the content directory and its
subdirectories.
- Added the same set of dictionary as suggested in the reference PR in
the issue thread. (Let me know if any more words need to be added)

---------

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Yuri Shkuro <github@ysh.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Spell Checker to CI h4shk4t/documentation
3 participants
@yurishkuro @h4shk4t @jaydee029