Grpc port #181
Merged
Grpc port #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
ghost
assigned 
objectiser
reviewed
Nov 26, 2018
| @@ -88,6 +88,9 @@ docker run \ | |||
| In the future we will support different service discovery systems to dynamically load balance | |||
| across several collectors ([issue 213](https://github.com/jaegertracing/jaeger/issues/213)). | |||
|
|
|||
| Or add `--reporter.type=grpc` and `--reporter.grpc.host-port=jaeger-collector.jaeger-infra.svc:14250` to use gRPC | |||
There was a problem hiding this comment.
This may be better above the previous In the future paragraph.
Do you need to say these options should be added to the agent?
There was a problem hiding this comment.
Do you need to say these options should be added to the agent?
This is agent section so I think people will understand.
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
objectiser
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jaegertracing/jaeger#773