fixing padding and spacing to get TOC to render right #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
✅ Deploy Preview for romantic-neumann-1959d7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yurishkuro
reviewed
Sep 17, 2024
| @@ -52,12 +52,13 @@ | |||
| position: fixed | |||
| bottom: 0% | |||
| top: 9rem | |||
| left: 3rem | |||
There was a problem hiding this comment.
I tried to play with this one and didn't understand what it affects, seems turning it off makes the sidebar actually larger
There was a problem hiding this comment.
I added this to fix some of the strangeness in the scroll bar, but it depends on the browser you test with. If you don't think we need it I can remove it, just let me know.
There was a problem hiding this comment.
no, it's good, I see what it's doing.
Tweaking spacing. Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Jonah Kowall <jkowall@kowall.net>
yurishkuro
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will fix the spacing on all of the docs to make the screen real state better with less white space. It makes
a bigger difference in the v2 docs with the new TOC.
I did some testing on smaller screens as well.
Happy to get feedback.