-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaeger] [jaeger-operator] add possibility of overriting the namespace #599
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Reza J. Bavaghoush <rzjfr@yahoo.com>
990f966
to
f936539
Compare
This is the first PR I see that changes both the jaeger and jaeger-operator charts at the same time. @rzjfr Regarding the jaeger chart upgrade, until now, one could override the namespace using |
Hi @pavelnikolov thanks a lot for the review, You are absolutely right, you can use So the idea is the change to be absolutely backward compatible, while adding that possibility if someone needed it. |
This is an interesting use case. I appreciate the backwards compatibility thinking, however, I was wondering if you are installing Jaeger in a namespace different than the (parent chart's) release namespace, then shouldn't you create that namespace as well? Have you tested if that change would actually work? |
Signed-off-by: Reza J. Bavaghoush <rzjfr@yahoo.com>
Signed-off-by: Reza J. Bavaghoush <rzjfr@users.noreply.github.com>
Hi again @pavelnikolov, |
Signed-off-by: Reza J. Bavaghoush <rzjfr@yahoo.com>
Signed-off-by: Reza J. Bavaghoush <rzjfr@yahoo.com>
@yurishkuro wdyt about updating both charts within the same PR? It seems that this isn't a common practice. |
@pavelnikolov I have not been involved in this repo's development, so don't have any strong opinion. There is a general principle of keeping PRs small, from that perspective I would split it into two, one per chart. But as far as any functional impact - I don't know. |
What this PR does
Adds possibility to override the namespace of the resources
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format,will close that issue when PR gets merged)
Checklist
[jaeger]
or[jaeger-operator]
)