Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Update OpenTracing to 1.6.0 #209

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

mdouaihy
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Update the version of OpenTracing to 1.6.0
  • GTest version was fixed to 1.8.0-hunter-p11 because the later versions seem to have a problem with the rpath making the unit test fail because the binaries are unable to locate the gtest libraries. This issue will be followed separately to avoid blocking this request.

This will also solve another problem reported by @Alek86 in #208. This was due to a bug in OpenTracing compile flags that was fixed with the latest release.

…ion seems to have a problem with rpath.

Signed-off-by: Mehrez DOUAIHY <mehrez.douaihy@gmail.com>
@mdouaihy
Copy link
Contributor Author

Hello @yurishkuro,

Would you please take a look?

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@yurishkuro
Copy link
Member

Travis is failing. I restarted once, it failed with the same errors.

@mdouaihy
Copy link
Contributor Author

This seems to be a technical problem at Travis or Ubuntu package servers level

W: The repository 'http://ppa.launchpad.net/couchdb/stable/ubuntu trusty Release' is not signed. W: Failed to fetch http://ppa.launchpad.net/pollinate/ppa/ubuntu/dists/trusty/main/binary-amd64/Packages Could not connect to ppa.launchpad.net:80 (91.189.95.83), connection timed out W: Failed to fetch http://ppa.launchpad.net/pollinate/ppa/ubuntu/dists/trusty/main/binary-i386/Packages Unable to connect to ppa.launchpad.net:http: W: Failed to fetch http://ppa.launchpad.net/pollinate/ppa/ubuntu/dists/trusty/main/i18n/Translation-en Unable to connect to ppa.launchpad.net:http: W: Failed to fetch http://ppa.launchpad.net/ubuntu-toolchain-r/test/ubuntu/dists/trusty/main/binary-amd64/Packages Unable to connect to ppa.launchpad.net:http: W: Failed to fetch http://ppa.launchpad.net/ubuntu-toolchain-r/test/ubuntu/dists/trusty/main/binary-i386/Packages Unable to connect to ppa.launchpad.net:http: W: Failed to fetch http://ppa.launchpad.net/ubuntu-toolchain-r/test/ubuntu/dists/trusty/main/i18n/Translation-en Unable to connect to ppa.launchpad.net:http: W: Failed to fetch http://ppa.launchpad.net/webupd8team/java/ubuntu/dists/trusty/main/binary-amd64/Packages Unable to connect to ppa.launchpad.net:http: W: Failed to fetch http://ppa.launchpad.net/webupd8team/java/ubuntu/dists/trusty/main/binary-i386/Packages Unable to connect to ppa.launchpad.net:http: W: Failed to fetch http://ppa.launchpad.net/webupd8team/java/ubuntu/dists/trusty/main/i18n/Translation-en Unable to connect to ppa.launchpad.net:http: W: Failed to fetch http://ppa.launchpad.net/couchdb/stable/ubuntu/dists/trusty/Release.gpg Unable to connect to ppa.launchpad.net:http: W: Failed to fetch http://ppa.launchpad.net/couchdb/stable/ubuntu/dists/trusty/main/binary-amd64/Packages Unable to connect to ppa.launchpad.net:http: W: Failed to fetch http://ppa.launchpad.net/couchdb/stable/ubuntu/dists/trusty/main/binary-i386/Packages Unable to connect to ppa.launchpad.net:http: W: Failed to fetch http://ppa.launchpad.net/couchdb/stable/ubuntu/dists/trusty/main/i18n/Translation-en Unable to connect to ppa.launchpad.net:http:

@mdouaihy
Copy link
Contributor Author

I run Travis on my branch before doing the PR and experienced same errors. I rerun the build and it passed.
https://travis-ci.org/mdouaihy/jaeger-client-cpp/builds/654680113?utm_medium=notification&utm_source=github_status

@yurishkuro yurishkuro closed this Feb 25, 2020
@yurishkuro yurishkuro reopened this Feb 25, 2020
@AppVeyorBot
Copy link

@yurishkuro yurishkuro merged commit 6f28823 into jaegertracing:master Feb 25, 2020
@suab321321
Copy link

suab321321 commented Feb 26, 2020

@yurishkuro the error is still there when I run cmake .. from build it shows me this output.
Screenshot from 2020-02-26 23-51-21

the error is in the Gtest packages, so I tried to run this package individually, I went inside the directory /.hunter/_Base/d45d77d/de38925/3b7ee27/Build/GTest and did cmake --build Build/ and this is the output I m getting

Screenshot from 2020-02-26 23-56-00

now I dont understand how to fix this.

OS - ubuntu 18.04
gcc - 9.2.1
g++ -9.2.1
branch - master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants