This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Record logs passed with Span::FinishWithOptions #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaeger cpp-client was previously dropping logs included in a FinishSpanOptions silently on the floor. Fixes jaegertracing#57 Signed-off-by: Craig Ringer <craig@2ndquadrant.com>
|
This requires OpenTracing master by the looks |
|
@isaachier This should be ready to merge now. |
|
Rebuilding now. Sorry for delay. |
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 88.46% 87.86% -0.61%
==========================================
Files 93 96 +3
Lines 2246 2291 +45
==========================================
+ Hits 1987 2013 +26
- Misses 259 278 +19
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jaeger cpp-client was dropping logs included in a FinishSpanOptions
silently on the floor. Append them to the log buffer during FinishWithOptions instead.
Fixes #57
Signed-off-by: Craig Ringer craig@2ndquadrant.com