Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Crossdock crash fix #228

Closed
wants to merge 7 commits into from

Conversation

isaachier
Copy link
Contributor

Fix #225

Isaac Hier added 7 commits November 14, 2017 13:13
Signed-off-by: Isaac Hier <ihier@uber.com>
Signed-off-by: Isaac Hier <ihier@uber.com>
Signed-off-by: Isaac Hier <ihier@uber.com>
Signed-off-by: Isaac Hier <ihier@uber.com>
Signed-off-by: Isaac Hier <ihier@uber.com>
Signed-off-by: Isaac Hier <ihier@uber.com>
@codecov
Copy link

codecov bot commented Nov 14, 2017

Codecov Report

Merging #228 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   81.99%   81.99%           
=======================================
  Files          51       51           
  Lines        3226     3226           
=======================================
  Hits         2645     2645           
  Misses        457      457           
  Partials      124      124
Impacted Files Coverage Δ
crossdock/client/trace.go 66.96% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b337ce...9b7a475. Read the comment docs.

@yurishkuro
Copy link
Member

could you squash and rebase from master? Not clear what's up with code coverage.

@isaachier
Copy link
Contributor Author

There are still panics with this fix. I think this might be related to jaegertracing/jaeger-idl#35, because my hand-fixed C++ thrift doesn't seem to conform with the input/output expected in the generated Go code. Unless you believe this is significant, I'm going to close this for now.

@isaachier isaachier closed this Nov 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants