Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only JSON.parse JSON strings in tags/logs values #162

Merged
merged 1 commit into from
Dec 26, 2017

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Dec 25, 2017

Fix #146.

Only applies JSON.parse(...) to the values of tags or log-fields when it returns an object.

Signed-off-by: Joe Farro <joef@uber.com>
@ghost ghost assigned tiffon Dec 25, 2017
@ghost ghost added the review label Dec 25, 2017
@codecov
Copy link

codecov bot commented Dec 25, 2017

Codecov Report

Merging #162 into master will decrease coverage by 0.15%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   92.77%   92.62%   -0.16%     
==========================================
  Files          85       85              
  Lines        1882     1884       +2     
  Branches      367      368       +1     
==========================================
- Hits         1746     1745       -1     
- Misses        124      126       +2     
- Partials       12       13       +1
Impacted Files Coverage Δ
...e/TraceTimelineViewer/SpanDetail/KeyValuesTable.js 77.77% <60%> (-22.23%) ⬇️
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js 88.88% <0%> (-1.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a53299e...66f0d7b. Read the comment docs.

@tiffon tiffon merged commit c8387b0 into master Dec 26, 2017
@ghost ghost removed the review label Dec 26, 2017
@yurishkuro yurishkuro deleted the issue-146-str-tags-converted-to-number branch January 29, 2020 15:06
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants