Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct duration format for scatter plot #266

Merged
merged 2 commits into from
Oct 12, 2018

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Oct 11, 2018

Fix #253.

Trace duration unit in scatterplot is always 'seconds'

Signed-off-by: Joe Farro <joef@uber.com>
@ghost ghost assigned tiffon Oct 11, 2018
@ghost ghost added the review label Oct 11, 2018
Signed-off-by: Joe Farro <joef@uber.com>
@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   77.08%   77.08%           
=======================================
  Files         135      135           
  Lines        2955     2955           
  Branches      613      613           
=======================================
  Hits         2278     2278           
  Misses        534      534           
  Partials      143      143
Impacted Files Coverage Δ
...nents/SearchTracePage/SearchResults/ScatterPlot.js 36.36% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bbe0ef...0bc4d65. Read the comment docs.

@yurishkuro yurishkuro merged commit feeaccd into master Oct 12, 2018
@ghost ghost removed the review label Oct 12, 2018
@yurishkuro yurishkuro deleted the issue-253-scatter-plot-y-units branch January 29, 2020 15:08
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
* Use correct duration format for scatter plot

Signed-off-by: Joe Farro <joef@uber.com>

* Fix issue with unit test

Signed-off-by: Joe Farro <joef@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants