Fix rendering X axis in TraceResultsScatterPlot - pass milliseconds to moment.js

[istrel]

Resolves #270

Which problem is this PR solving?

This PR fixes rendering X axis values in TraceResultsScatterPlot.

Short description of the changes

Now it passes milliseconds into moment.js function call. Previously there were milliseconds multiplied by 1000 (i.e. raw timestamp from server)

[codecov]

Codecov Report

Merging #274 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   77.08%   77.15%   +0.06%     
==========================================
  Files         135      135              
  Lines        2955     2955              
  Branches      613      613              
==========================================
+ Hits         2278     2280       +2     
+ Misses        534      532       -2     
  Partials      143      143

Impacted Files	Coverage Δ
...nents/SearchTracePage/SearchResults/ScatterPlot.js	72.72% <100%> (+36.36%)	⬆️
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js	87.03% <0%> (-3.71%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feeaccd...78929b0. Read the comment docs.

[yurishkuro]

what does the moment() function do?

[istrel]

moment - is the main function of moment.js framework - https://momentjs.com/

It may accept different inputs (strings, Date objects, timestamps). Here it accepts timestamp (number of milliseconds since 1 January 1970 UTC)

[yurishkuro]

Thanks.

While this may be an OK fix for this specific issue, I think a bigger problem is that we have to do that in the first place. I would expect the UI to have some domain model of the trace and expose the timestamps not in raw microseconds format, but in some structured representation, so that the presentation code wouldn't have to do these conversions all over the place.

[yurishkuro]

Is it possible to add tests?

[istrel]

I guess, It's possible to add tests.

But I have to expose ScatterPlotImpl only for testing purposes to do so.

[istrel]

I've added tests.

Note: In order to test axis rendering, I've exported ScatterPlotImpl.

[istrel]

@yurishkuro Could you please tell me what to do next with this PR?

[yurishkuro]

Thanks!

@tiffon is travelling, should be back later this week, I would like him to review.

[tiffon]

Looks great! Thanks for your contribution! 🎉

[tiffon]

👍