Remove unused NewOptionsFromConfig (#2866)

Signed-off-by: sheetalsingala <ssingala@redhat.com>
jaegertracing · Mar 5, 2021 · b950c55 · b950c55
1 parent 2fff3ca
commit b950c55
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 55 deletions.
diff --git a/plugin/storage/cassandra/factory_test.go b/plugin/storage/cassandra/factory_test.go
@@ -25,7 +25,6 @@ import (
 	"go.uber.org/zap"
 
 	"github.com/jaegertracing/jaeger/pkg/cassandra"
-	cassCfg "github.com/jaegertracing/jaeger/pkg/cassandra/config"
 	"github.com/jaegertracing/jaeger/pkg/cassandra/mocks"
 	"github.com/jaegertracing/jaeger/pkg/config"
 	"github.com/jaegertracing/jaeger/pkg/testutils"
@@ -193,14 +192,3 @@ func TestInitFromOptions(t *testing.T) {
 	assert.Equal(t, o.GetPrimary(), f.primaryConfig)
 	assert.Equal(t, o.Get(archiveStorageConfig), f.archiveConfig)
 }
-
-func TestNewOptions(t *testing.T) {
-	primaryCfg := cassCfg.Configuration{Keyspace: "primary"}
-	archiveCfg := cassCfg.Configuration{Keyspace: "archive"}
-	o := NewOptionsFromConfig(primaryCfg, archiveCfg)
-	assert.Equal(t, primaryCfg, o.Primary.Configuration)
-	assert.Equal(t, primaryStorageConfig, o.Primary.namespace)
-	assert.Equal(t, 1, len(o.others))
-	assert.Equal(t, archiveCfg, o.others[archiveStorageConfig].Configuration)
-	assert.Equal(t, archiveStorageConfig, o.others[archiveStorageConfig].namespace)
-}
diff --git a/plugin/storage/cassandra/options.go b/plugin/storage/cassandra/options.go
@@ -111,22 +111,6 @@ func NewOptions(primaryNamespace string, otherNamespaces ...string) *Options {
 	return options
 }
 
-// NewOptionsFromConfig creates Options from primary and archive config
-func NewOptionsFromConfig(primary config.Configuration, archive config.Configuration) *Options {
-	return &Options{
-		Primary: namespaceConfig{
-			namespace:     primaryStorageConfig,
-			Configuration: primary,
-		},
-		others: map[string]*namespaceConfig{
-			archiveStorageConfig: {
-				namespace:     archiveStorageConfig,
-				Configuration: archive,
-			},
-		},
-	}
-}
-
 // AddFlags adds flags for Options
 func (opt *Options) AddFlags(flagSet *flag.FlagSet) {
 	addFlags(flagSet, opt.Primary)

diff --git a/plugin/storage/es/factory_test.go b/plugin/storage/es/factory_test.go
@@ -218,14 +218,3 @@ func TestInitFromOptions(t *testing.T) {
 	assert.Equal(t, o.GetPrimary(), f.primaryConfig)
 	assert.Equal(t, o.Get(archiveNamespace), f.archiveConfig)
 }
-
-func TestNewOptions(t *testing.T) {
-	primaryCfg := escfg.Configuration{IndexPrefix: "primary"}
-	archiveCfg := escfg.Configuration{IndexPrefix: "archive"}
-	o := NewOptionsFromConfig(primaryCfg, archiveCfg)
-	assert.Equal(t, primaryCfg, o.Primary.Configuration)
-	assert.Equal(t, primaryNamespace, o.Primary.namespace)
-	assert.Equal(t, 1, len(o.others))
-	assert.Equal(t, archiveCfg, o.others[archiveNamespace].Configuration)
-	assert.Equal(t, archiveNamespace, o.others[archiveNamespace].namespace)
-}
diff --git a/plugin/storage/es/options.go b/plugin/storage/es/options.go
@@ -117,22 +117,6 @@ func NewOptions(primaryNamespace string, otherNamespaces ...string) *Options {
 	return options
 }
 
-// NewOptionsFromConfig creates Options from primary and archive config
-func NewOptionsFromConfig(primary config.Configuration, archive config.Configuration) *Options {
-	return &Options{
-		Primary: namespaceConfig{
-			namespace:     primaryNamespace,
-			Configuration: primary,
-		},
-		others: map[string]*namespaceConfig{
-			archiveNamespace: {
-				namespace:     archiveNamespace,
-				Configuration: archive,
-			},
-		},
-	}
-}
-
 func (config *namespaceConfig) getTLSFlagsConfig() tlscfg.ClientFlagsConfig {
 	return tlscfg.ClientFlagsConfig{
 		Prefix:         config.namespace,