Skip to content

Commit

Permalink
Update static UI assets path in contrib doc (#2548)
Browse files Browse the repository at this point in the history
Signed-off-by: albertteoh <albert.teoh@logz.io>
  • Loading branch information
albertteoh committed Oct 9, 2020
1 parent 600d023 commit e3a73e1
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,22 +30,14 @@ Then install dependencies and run the tests:
git submodule update --init --recursive
make install-tools
make test
#if you wish to build platform binaries locally - the step below is needed.
# if you wish to build platform binaries locally - the step below is needed.
make build-ui
```

### Running local build with the UI

The `jaeger-ui` submodule contains the source code for the UI assets (requires Node.js 6+). The assets must be compiled first with `make build-ui`, which runs Node.js build and then packages the assets into a Go file that is `.gitignore`-ed. The packaged assets can be enabled by providing a build tag `ui`, e.g.:

```
$ go run -tags ui ./cmd/all-in-one/main.go
```

Alternatively, the path to the built UI assets can be provided via `--query.static-files` flag:

```
$ go run ./cmd/all-in-one/main.go --query.static-files jaeger-ui/build
$ make run-all-in-one
```

## Project Structure
Expand Down

0 comments on commit e3a73e1

Please sign in to comment.