Skip to content

Commit

Permalink
Fix permission failed on checks-run (#5041)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
-
#5035 (comment)

## Description of the changes
- The logs from
https://github.com/jaegertracing/jaeger/actions/runs/7324976182/job/19949034415#step:8:67
show:
> github.GithubException.GithubException: 403 {"message": "Resource not
accessible by integration", "documentation_url":
"https://docs.github.com/rest/checks/runs#create-a-check-run"}

This is because it needs write permission on the PR check runs to
provide a summary.

- The alternative is to disable test summary in the PR checks.

## How was this change tested?
- Ran this in my fork earlier.

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits

Signed-off-by: Albert Teoh <albert@packsmith.io>
Co-authored-by: Albert Teoh <albert@packsmith.io>
  • Loading branch information
albertteoh and Albert Teoh committed Dec 26, 2023
1 parent a798e25 commit fad13b8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci-unit-tests-go-tip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
# See https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
permissions: # added using https://github.com/step-security/secure-workflows
contents: read
checks: write

jobs:
unit-tests-go-tip:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ concurrency:
# See https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
permissions: # added using https://github.com/step-security/secure-workflows
contents: read
checks: write

jobs:
unit-tests:
Expand Down

0 comments on commit fad13b8

Please sign in to comment.