-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return uptime
or something similar for /health
endpoint
#1450
Comments
I can probably tackle this when I get some time. |
We indicate the status via HTTP status code, but I don't mind returning it in JSON as well. And I like the idea of uptime, so: {
"status": "unavailable"
}
{
"status": "up",
"uptime": "1h20m"
} |
The initial idea was to indeed return some content, like the status of the connection to the backing storage, but we never ended up doing that. Uptime is indeed something we can return right now. Perhaps another field indicating when it has started could also be helpful? Parsing |
Return 200 OK for status `ready` and `upTimeStats` Resolves jaegertracing#1450
Return 200 OK for status `ready` and `upTimeStats` Resolves jaegertracing#1450
Return 200 OK for status `ready` and `upTimeStats` Resolves jaegertracing#1450 Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com>
Return 200 OK for status `ready` and `upTimeStats` Resolves jaegertracing#1450 Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com>
* Return info msg for `/health` endpoint Return 200 OK for status `ready` and `upTimeStats` Resolves #1450 Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com> * Address PR comments Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com> * Fix failing test Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com> * Address PR comments Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com> * Retrigger tests Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com> * Retrigger tests Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com> * Make thread-safe Signed-off-by: Yuri Shkuro <ys@uber.com>
Currently, the
/health
endpoint returns a204
when it becomesReady
, which isn't a great indicator of whether the service is healthy or not.However, it would be nice to return a
200
and something like:{"ok":true,"status":"up"}
or even{"uptime":1h20m}
, etc.The text was updated successfully, but these errors were encountered: