Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Jager Collector to work with Kafka With Basic Authentication #1966

Closed
vipinvkmenon opened this issue Dec 6, 2019 · 3 comments · Fixed by #1983
Closed

Configure Jager Collector to work with Kafka With Basic Authentication #1966

vipinvkmenon opened this issue Dec 6, 2019 · 3 comments · Fixed by #1983

Comments

@vipinvkmenon
Copy link

Requirement -

Looking to integrate with Kafka which is provided by a platform Service. However, the kafka service provided by the platform only supports basic authentication

Problem -

The jager documentation or options did not indicate support for Kafka basic authentication

As a result, we would not be able to integrate our Jaeger solution with existing Kafka Services provided with our platform

Proposal -

Jaeger to support authentication mechanisms provided by Kafka

Any open questions to address

Is it available? Is it documentation that I possibly missed? Or is there a reason why it was not implemented?
(Maybe some best practise that I am unaware of)

@yurishkuro
Copy link
Member

Wouldn't basic auth be sent in clear text? I can see how it can be useful with HTTPS, but without TLS is sounds like an anti-pattern.

But, if the sarama driver supports it, it is fairly easy to add.

@vipinvkmenon
Copy link
Author

@yurishkuro
Thank you for your quick reply. Also Loved your book :)
In this case, the Kafka service provides IPs that can only be accessed within the boun application
IE The IP cannot be externally accessed and only the service/app (Jaeger Collector/Jaeger Ingestor) bound to the Kafka service would have access to the network which has Kafka in it.

@chandresh-pancholi
Copy link
Contributor

I am picking it up if anyone haven't started.

chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Dec 18, 2019
…jaegertracing#1966

Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Dec 23, 2019
…rtracing#1966

Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
yurishkuro pushed a commit that referenced this issue Dec 31, 2019
#1983)

* Configure Jager Collector to work with Kafka With Basic Authentication #1966

Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>

* Changing method name from addPlainTextFlag to addPlainTextFlags #1966

Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants