Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct grpc logs to Zap logger #1606

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jun 14, 2019

Resolves #1602, supersedes #1330.

Sample output:

{"level":"info","ts":1560530693.131958,"caller":"grpc/clientconn.go:242","msg":"parsed scheme: \"\"","system":"grpc","grpc_log":true}
{"level":"info","ts":1560530693.1319869,"caller":"grpc/clientconn.go:248","msg":"scheme \"\" not registered, fallback to default scheme","system":"grpc","grpc_log":true}
{"level":"info","ts":1560530693.132017,"caller":"grpc/resolver_conn_wrapper.go:113","msg":"ccResolverWrapper: sending update to cc: {[{127.0.0.1:14250 0  <nil>}] }","system":"grpc","grpc_log":true}
{"level":"info","ts":1560530693.132215,"caller":"base/balancer.go:76","msg":"base.baseBalancer: got new resolver state: {[{127.0.0.1:14250 0  <nil>}] }","system":"grpc","grpc_log":true}
{"level":"info","ts":1560530693.1323001,"caller":"base/balancer.go:130","msg":"base.baseBalancer: handle SubConn state change: 0xc000256040, CONNECTING","system":"grpc","grpc_log":true}
{"level":"info","ts":1560530693.132832,"caller":"grpc/clientconn.go:1139","msg":"grpc: addrConn.createTransport failed to connect to {127.0.0.1:14250 0  <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:14250: connect: connection refused\". Reconnecting...","system":"grpc","grpc_log":true}
{"level":"info","ts":1560530693.132919,"caller":"base/balancer.go:130","msg":"base.baseBalancer: handle SubConn state change: 0xc000256040, TRANSIENT_FAILURE","system":"grpc","grpc_log":true}

Signed-off-by: Yuri Shkuro <ys@uber.com>
@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #1606 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1606   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         191      191           
  Lines        9162     9162           
=======================================
  Hits         9053     9053           
  Misses         85       85           
  Partials       24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ff96f...0ce3d68. Read the comment docs.

@yurishkuro yurishkuro merged commit eb6640b into jaegertracing:master Jun 14, 2019
@yurishkuro yurishkuro deleted the fix-1602 branch June 14, 2019 17:12
jan25 pushed a commit to jan25/jaeger that referenced this pull request Jun 16, 2019
Signed-off-by: Yuri Shkuro <ys@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encode gRPC logs with zap and emit to stdout
2 participants